Skip to content

fix(fleet): date the logs-accepts-only-the-id probe row - #7522

Merged
kyle-sexton merged 4 commits into
mainfrom
work-resolve-issue/issue-6880-38691665284-1
Oct 17, 2026
Merged

kyle-sexton merged 4 commits into
mainfrom
work-resolve-issue/issue-6880-38691665284-1

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Closes #6880

Hold: a human merges this

Summary

Opened by the work-resolve-issue lane. The run's own summary:

The relay reference row for R2 said logs accepted only the id, reading as current behavior. It now states it was observed on Claude Code 2.1.284 and that later builds accept part of a session name, per the existing fleet 0.2.4 changelog. Added a patch changelog fragment for fleet.

Not verified

  • No fresh re-probe on a current build; the row was dated instead. The 'later builds accept part of a session name' wording restates the repo's own fleet 0.2.4 changelog, not a source read this run.
  • Fresh-context subagent review, build/test/lint and class audits were not run; the diff is one table cell plus a changelog fragment, reviewed by hand.

Fix

  • plugins/fleet/skills/reach/reference/relay.md: the R2 row (line 218, not 203 as the issue says) now carries the probe version and a note that later builds differ
  • .changes/fleet/fix-6880-date-logs-probe-row-7c2e41a9.md: patch fragment

Verification

The run reports:

Left out: the items under Not verified.

Related

#6880

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @melodic-automation-lanes[bot]'s task in 30s —— View job


Security review complete

  • Gather context (PR diff, changed files)
  • Apply skip gate
  • Review diff for security-relevant surface
  • Post findings / no-findings summary

Diff scope: .changes/fleet/fix-6880-date-logs-probe-row-7c2e41a9.md (new changelog fragment) and plugins/fleet/skills/reach/reference/relay.md line 218 (one table-cell edit, permalink).

This PR only adds a date/version qualifier to an existing documentation row describing past probe results, plus a corresponding patch changelog fragment. It contains no executable code, no configuration changes, and no deletion or weakening of a standing instruction, guardrail, or allow/deny list — the instruction-surface-deletion lens does not apply here, since the edit adds clarifying context rather than removing a rule. No injection surfaces, auth/access-control logic, or secret handling are touched.

No security issues found.

claude-lane-summary: lane=claude-security-review sha=68f545397cd93b8c5d625a423cf008d328836302 run=38691885333

@claude

claude Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @melodic-automation-lanes[bot]'s task in 1m 1s —— View job


CI code review

  • Gather context (diff, changed files, relay reference)
  • Check skip gate (not applicable — small but reviewable doc/content change)
  • Review against CLAUDE.md/AGENTS.md/REVIEW.md criteria and the skill-bodies-state-current-rules convention
  • Post findings

Reviewed the two changed files: the new changelog fragment and the one-line edit to plugins/fleet/skills/reach/reference/relay.md (R2 row). One finding posted inline.

claude-lane-summary: lane=claude-review sha=68f545397cd93b8c5d625a423cf008d328836302 run=38691885430

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed e4fea6810f2f55f4f08f37cf51550fa2f4a48d79: 0 finding(s), 0 as inline comments.

No security issues found. PR #7522 (head e4fea68) adds a changelog fragment and appends "(observed on 2.1.284)" to one probe-result row in plugins/fleet/skills/reach/reference/relay.md. The change is descriptive reference text. It deletes, narrows or softens no standing instruction, guardrail, hook allowlist or permission rule, so the instruction-surface lens found nothing to check. It adds no code, workflow, secret handling or trust-boundary change. I did not consult the instruction exception register because the diff removes no rule.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed e4fea6810f2f55f4f08f37cf51550fa2f4a48d79: 0 finding(s), 0 as inline comments.

No findings. I reviewed the full 2-file diff and found nothing to block or flag.

  • plugins/fleet/skills/reach/reference/relay.md:218: the R2 row now ends the logs clause with "(observed on 2.1.284)". The file already ties the same probe to 2.1.284 (lines 141, 146 and 196), so the version is consistent with the rest of the file.
  • .changes/fleet/fix-6880-date-logs-probe-row-7c2e41a9.md: this is a patch fragment with a ### Changed section. fleet is listed in scripts/fragment-plugins.txt, so a fragment is the right mechanism. I did not run check-changelog-fragments. The PR's claim that it passed is the author's and unverified.

One mismatch is not tied to a changed line. The PR body's Summary says the row "states it was observed on Claude Code 2.1.284 and that later builds accept part of a session name". The diff only adds the version stamp and does not mention the later behavior. The body also says the row "now carries the probe version and a note that later builds differ", which the diff does not show either. The change itself still does what the issue asked: the row no longer reads as current behavior. Whoever merges may want the body trimmed to match.

The row keeps the dated observation (2.1.284); the claim about later
builds had no pointer, as-of date or recheck trigger. SKILL.md holds
the pointer for deciding whether a lane accepts a session name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CQKJiE8NBix1bgynWFSkqp
@claude

claude Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 27s —— View job


Security review complete

  • Gather context (incremental diff, PR body, prior review state)
  • Apply skip gate
  • Review diff for security-relevant surface
  • Post findings / no-findings summary

Diff scope (incremental, since 68f5453): plugins/fleet/skills/reach/reference/relay.md line 218 only — the R2 probe row's parenthetical changed from (observed on 2.1.284; later builds accept part of a session name, per the fleet 0.2.4 changelog) to (observed on 2.1.284), dropping the restated-upstream-behavior clause flagged by the prior code-review pass (permalink).

This is a prose-only trim to a documentation reference row describing a past probe observation. It removes no guardrail, allow/deny rule, or standing instruction — the removed clause was a factual claim about CLI version behavior, not a control — so the instruction-surface-deletion lens doesn't apply. No executable code, config, auth/access-control logic, injection surface, or secret handling is touched.

No security issues found.

claude-lane-summary: lane=claude-security-review sha=6bfb8451007a3a3b7d589a77d410a9b333b59850 run=38758790329

@claude

claude Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 50s —— View job


CI code review

  • Gather context (incremental diff, prior review)
  • Check skip gate (not applicable — reviewable incremental change)
  • Review changed lines against criteria
  • Post findings

Incremental scope: plugins/fleet/skills/reach/reference/relay.md line 218 (R2 row), per .claude-lane/incremental.diff. This is the only change since 68f5453.

The previous finding on this row flagged the inline clause (observed on 2.1.284; later builds accept part of a session name, per the fleet 0.2.4 changelog) as a restatement of volatile upstream CLI behavior without a pointer/as-of/recheck-trigger block.

This push drops the "later builds accept..." clause entirely, leaving just (observed on 2.1.284). That resolves the finding: the row no longer asserts anything about current or future upstream behavior, and the bare version note is consistent with — and redundant to — the table-wide Claim/Basis block already at relay.md:194-196 ("As of 2026-09-29, Claude Code 2.1.284") and the Pointer/As of/Recheck trigger block at lines 203-211, which already cover this whole "Verified behavior" table.

No new findings.

claude-lane-summary: lane=claude-review sha=6bfb8451007a3a3b7d589a77d410a9b333b59850 run=38758790352

@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit db83d05 Oct 17, 2026
21 checks passed
@kyle-sexton
kyle-sexton deleted the work-resolve-issue/issue-6880-38691665284-1 branch October 17, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fleet/reach: date the logs-accepts-only-the-id probe row as a past observation

1 participant